Skip to content

danger: classifier hardening wave - #268

Merged
jkyberneees merged 3 commits into
mainfrom
fix/danger-classifier-hardening
Sep 25, 2026
Merged

jkyberneees merged 3 commits into
mainfrom
fix/danger-classifier-hardening

Conversation

@jkyberneees

Copy link
Copy Markdown
Contributor

Summary

  • Gate builtin env-dump builtins (set, set -o, export/declare/typeset -p and flag-only -x) as system_write
  • Generalize fork-bomb detection beyond the ':' name (requires recursive spawn; benign recursion unblocked)
  • Fix extractSubstitutions double-quote escape desync that could hide substitution bodies
  • Run isRawBlocked before allowlist match in ActionForCommand
  • Friction prompt re-prompts once on reflex answers instead of silent deny
  • top added to safeCommands; dead writePrefixes comment fixed; duplicate openssl egress branch removed
  • New regression tests for all of the above (RED-first)

Test plan

  • go test -count=1 ./internal/danger/ — green
  • go vet ./internal/danger/ — clean
  • 2-expert adversarial review of the diff; both confirmed findings fixed and re-verified

…c, allowlist bypass)

- Gate builtin env dumps (set, set -o, export -p, declare/typeset -p) as system_write
- Generalize fork-bomb detection beyond the ':' name (RE2-safe, code-checked match)
- Fix extractSubstitutions double-quote escape desync hiding substitution bodies
- Run isRawBlocked before allowlist match in ActionForCommand
- Friction prompt re-prompts once on reflex answers instead of silent deny
- Fix dead writePrefixes comment; remove duplicate openssl egress branch
- Pin dynamic-subst write verbs, clobber redirects, and deep-nesting termination with tests
- Flag-only declare/typeset -x prints all exported vars -> system_write;
  assignments or name operands keep the declaration semantics
- isNamedForkBomb requires a pipe/ampersand in the body so plain
  recursive functions are not blocked
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
odek 6172583 Commit Preview URL

Branch Preview URL
Sep 25 2026, 08:07 PM

@jkyberneees
jkyberneees merged commit e52aa4c into main Sep 25, 2026
10 checks passed
@jkyberneees
jkyberneees deleted the fix/danger-classifier-hardening branch September 25, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant