Repository navigation
feat: show unsupported files in the article navigator - #667
Merged
Merged
Conversation
The rendered-images fixtures move into their own folder because the navigator now lists their SVGs, and any extra row at the shared fixture root pushes document-lifecycle's target out of the virtualized list that findTreeItem searches without scrolling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The article navigator listed only Markdown files and directories, so a folder holding images, PDFs, or other files looked empty. It now lists every non-ignored regular file and mutes those Leafdown cannot open, without widening which files Leafdown edits.
unsupportedFilenode kind rather than reusingfile, so every existingfileconsumer (opening, the article count and filter, folder search and replace, wiki-link completion, index lookup,isEmpty) stays Markdown-only. The scan also skips Leafdown's*.leafdown-tmpsave staging files, which a scan racing a save would otherwise list.aria-descriptionsay "Leafdown can only open Markdown files." Click, Enter, and Space only focus the row. They sort among articles under the chosen order, so a folder holding only such files expands while an empty folder has nothing to expand.possibleEntryPaths, and the navigator refreshes when one names any entry it shows, not only a directory.Related Issue
Closes #649
Verification
pnpm checkpassed.Not verified: the new
folder-watcherdesktop test, which creates and deletes real files and checks rows and activation, was not run locally, and neither was the image fixtures' move. The app was not run, so the muted styling was not checked visually. Scan and render cost for folders with many non-Markdown files, such as a photo library, was not measured.Notes
document-lifecycle's target out of the virtualized list thatfindTreeItemsearches without scrolling.