Repository navigation
fix(browser-actions): reject empty video recordings - #2562
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2558. Finalize Playwright’s video before adopting it, reject empty source or copied artifacts, and surface recording failures in errors.jsonl and the command result rather than reporting success.
What changed
How to test
npm ci && npm run build && npm run test:browser-video-capture; expect passes as recorded by Cook's deterministic gate.Compatibility
Successful video captures retain their existing artifact path and summary shape. Invalid or empty recordings now fail loudly instead of returning success; on video failure, `errors.jsonl` is emitted even when errors were not explicitly requested. No CHANGELOG or version strings were changed.
Evidence
npm ci && npm run build && npm run test:browser-video-capture: status=succeeded; candidate commita1317ed97ea8e67f83415edc9c46637b42e1055d, tree4b0fd8d72aa23385b5a38982ffffe2bdc97c7c8c, fingerprint7c7fcff1f9c0e1f3b1b79932fc19ba99ed2ecf9bdfcd7cafe638a3cc30943b45; durable gategate-1AI assistance