Repository navigation
feat(mobile): Library tracks as rows, search-style filter, row press animation - #14701
Merged
Merged
Conversation
…animation Library's Tracks tab renders the same TrackRow as Trending behind the track_rows flag: artwork, title with the offline download indicator, artist with badges, duration. Tap plays, long-press opens the actions. The old TrackList card stays for the flag-off path. FilterInput is now a flush search field (surface2 pill, search icon, clear button) instead of a Paper card. Every caller keeps the same props. TrackRow presses settle the row with a scale and surface2 highlight; a long-press dips further and springs back as the actions open. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #14700: the Library catches up with Trending, and rows get a real press animation.
Library Tracks tab (behind
track_rows, on in production): the bordered card of art-less rows is replaced by the sameTrackRowTrending uses, full-bleed: 48px artwork with the playing overlay, title with the offline download indicator, artist with badges, duration. Tap plays, long-press opens the actions (now including favorite/repost/share since there is no kebab). The flag-off path keeps the oldTrackList.Filter field:
FilterInputis a flush search-style pill (surface2, search icon, clear button) instead of a shadowed Paper card with a filter icon. Same props, so Albums/Playlists, Listening History, Add to Collection and the feature-flag screen pick it up too. The client-side filter and 250 ms server query debounce are unchanged.Row press animation (
TrackRow, so Trending/profiles/search get it too): press-in scales the row to 0.985 with a surface2 highlight; release springs back. A long-press dips to 0.96 and springs back as the actions open, alongside the existing haptic. Reanimated 4 on the UI thread; the highlight is an absolute overlay so no color interpolation through transparent.Tested on the iOS 26.5 simulator (1.5.190 Release build with this bundle swapped in, signed in): Library rows and artwork, tap to play with the equalizer overlay, long-press menu, typing a filter and clearing it, pagination skeletons. Mobile
tscand eslint are clean. Not tested: Android, offline mode with downloaded tracks, VoiceOver.🤖 Generated with Claude Code