Repository navigation
fix(web): synchronize iOS keyboard edits (#830) - #839
HadrienKerlero wants to merge 2 commits into
Conversation
Keep one native-input owner per iOS terminal and reconcile keyboard edits without duplicate producers. Preserve session-bound input ordering, local-echo Unicode deletion, and visual caret geometry. Cover device event sequences and lifecycle handoffs; remove obsolete helpers and source-text-only regression tests. Fixes Ark0N#830
|
Thank you for this, and for the device testing with the reporter. The PR gives each terminal pane on iOS a native-input owner, so suggestions, phrase replacement, dictation and held delete reach the PTY as one ordered edit. It also adds a per-session FIFO that keeps delayed Enter and paste writes with the session they were typed for. The gate passes here (757 files, 17,284 tests), as do the new iOS browser suite and the overlay package. A few things need to change before merge:
Push the fixes to this branch and the PR goes back into review. |
Keep the unsent draft out of slash-command keys; settle the iOS owner without flushing local echo. Restore the overlay last-prompt fallback and the Ark0N#520 Shift/Ctrl+Enter gate guard. Pin the xterm privates the iOS owner needs; retarget browser/mobile harnesses to the session FIFO edge. Document the session FIFO invariants and link Ark0N#830 for the device sequences.
|
Thanks for the thorough review. All six points are addressed in 89d6a9e on this branch.
Verification on this branch:
|
Fixes #830
Keep xterm's helper textarea in sync with native iOS editing instead of supplementing xterm's first-character keypress output.
Changes
white-space: pre. Keep dictated line breaks editable in the native field but project them to spaces, as requested by the reporter; only explicit Enter submits.Clean-code review
.github/CONTRIBUTING.md: focused issue change, tests and patch changeset, no version bump orCHANGELOG.mdedit.Device acceptance
The reporter tested the standalone probe and then the integrated isolated beta on their iPhone and confirmed the remaining keyboard features work. Copy/paste feature work was explicitly excluded; existing Codeman clipboard features are preserved.
The browser replays preserve the logged iOS event order, multi-character
keyvalues, first-lettercharCode, andcomposed: true. They are regression coverage, not a claim that Chromium emulates the iOS keyboard.Delivery boundary
The FIFO guarantees session destination and enqueue ordering through Codeman's existing reliable transport. It does not introduce new ACK/completion guarantees or redesign reconnect, wake-buffering, or named-key transport behavior.
Verification on current upstream
masternpm test: 757 test files passed, 17,284 tests passed; 1 file / 13 tests skipped by the repository's existing conditions.npm run build,typecheck,lint,format:check,check:frontend-syntax,check:frontend-dead,check:browser-excludes,check:public-assets, andcheck:lockfile: passed.master(e99b42c3), not the reporter's modified installation.