Repository navigation
Conversation
codeman tui <session> takes a list number or a session name. Digits only stay a number; anything else matches the session name exactly (case-sensitive, never a prefix, folder or prompt). Names are not unique, so two live matches refuse and print their numbers; a name only a RECENT row carries says the session has finished. The target is resolved before the TTY check, so scripts get these answers without a terminal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for this, and for splitting it out of Discussion #833. It lets The code is in good shape. A few small docs things:
You don't need to push again for any of this: I will apply 1 to 3 on top when merging. Part 2 ( |
Review on Ark0N#834: drop the Prettier reflow of docs/tui.md and keep only the new example line and paragraph, put "two" back in the fast-paths sentence, list <n|name> in the tui-app.ts fileoverview, and add a codeman tui <name> line to the README and the Remote Access wiki page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for the review. All four are in 8b809da, so nothing to apply on merge:
typecheck, lint, format:check and the pre-push static checks pass. Posted with Claude Code on behalf of @kkalisz. |
|
Thanks @kkalisz, and thanks for the quick turnaround on the first round. With this, All four points from the first round are in At merge time I will add the matching example line to |
Review on Ark0N#834. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks again @kkalisz. This PR lets I checked the head commit ( There is one small wording change, which I will make on top when merging, so you don't need to push anything:
With that change on top, this is ready to merge. |
The --list column is rowLabel() cut to 48 characters: an unnamed session shows its folder, a long name ends in an ellipsis, and neither resolves as a name. Point at attaching by number instead. Review on Ark0N#834. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Good catch on the typecheck, format:check, the pre-push static checks, Posted with Claude Code on behalf of @kkalisz. |
|
Thanks @kkalisz, and thanks for the quick turnaround on every round. This PR lets I checked the head commit ( There is nothing else you need to do. It's ready to merge as it stands. |
Part 1 of Discussion #833. Part 1 stands on its own; part 2 (
--new) waits for your view there.Problem
codeman tui <n>attaches by list number, but the number changes whenever sessions move betweenNEEDS YOU / WORKING / IDLE, so you can't remember it, alias it or script it. From a fresh SSH
login there's no stable way to say "take me back to the
docssession".Change
codeman tui <session>takes a number or a session name.0and out-of-range keep their messages).the folder or a prompt.
codeman tui <number>. A name only a RECENT row carries says the session has finished ratherthan "not found".
"ambiguous" without a terminal. (
codeman tui 99piped now says "there is no session 99" insteadof "needs an interactive terminal"; both exit 1.)
state.json, namesincluded.
Code:
resolveAttachTarget()andattachTargetError()insrc/tui/tui-app.tsare pure;runTuiAttach()takesnumber | string;src/cli.tsroutes digits vs names.Tests
test/tui/tui-app.test.ts: position vs name, exact and case-sensitive, no prefix, ambiguouspositions, finished vs missing, the wording of each refusal.
test/tui/tui-e2e.test.ts(piped, against the fake server): a live name gets past resolutionto the TTY refusal; missing, finished and ambiguous names; digits still a number.
docs/tui.md,CLAUDE.mdone-liner, changeset.npm run typecheck,lint,format:check,check:frontend-syntax,check:browser-excludes,npm test: all TUI and CLI tests pass. On this Mac 99 tests in 21 other files fail identically on plain master (/varvs/private/varpaths, locally installed models, watcher timing); CI runs on Linux.Note:
codeman tui (under a pty) > says so when the dialog has already left the screenis flakyon this machine on plain master too (2 of 4 runs failed with no changes); it is unrelated to this
PR.
Opened with Claude Code on behalf of @kkalisz.
🤖 Generated with Claude Code