Skip to content

Antalya-26.8: Fix build #2592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zvonand merged 1 commit into from
Oct 18, 2026
Merged

Antalya-26.8: Fix build #2592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/Storages/ObjectStorage/DataLakes/Iceberg/AlterDropPartitionExecutor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ AlterDropPartitionExecutor::AlterDropPartitionExecutor(
const IcebergMetadata & metadata_,
ContextPtr context_,
ObjectStoragePtr object_storage_,
ExternalStorageCache & external_storages_,
const PersistentTableComponents & components_,
const DataLakeStorageSettings & data_lake_settings_,
String write_format_,
Expand All @@ -223,6 +224,7 @@ AlterDropPartitionExecutor::AlterDropPartitionExecutor(
, metadata(metadata_)
, context(context_)
, object_storage(std::move(object_storage_))
, external_storages(external_storages_)
, components(components_)
, data_lake_settings(data_lake_settings_)
, write_format(std::move(write_format_))
Expand Down Expand Up @@ -365,7 +367,8 @@ AlterDropPartitionExecutor::discoverTargetFilePaths(const SnapshotState & state,

for (const auto & manifest_key : state.snapshot->manifest_list_entries)
{
auto handle = getManifestFileEntriesHandle(object_storage, components, context, log, manifest_key, state.schema_id);
auto handle = getManifestFileEntriesHandle(
object_storage, components, context, log, manifest_key, state.schema_id, external_storages);

collect(handle.getFilesWithoutDeleted(FileContentType::DATA));
collect(handle.getFilesWithoutDeleted(FileContentType::POSITION_DELETE));
Expand Down Expand Up @@ -460,7 +463,8 @@ AlterDropPartitionExecutor::buildDropPlan(const SnapshotState & state, const Tar

for (const auto & manifest_key : state.snapshot->manifest_list_entries)
{
auto handle = getManifestFileEntriesHandle(object_storage, components, context, log, manifest_key, state.schema_id);
auto handle = getManifestFileEntriesHandle(
object_storage, components, context, log, manifest_key, state.schema_id, external_storages);

size_t entries_to_keep = 0;
size_t entries_to_remove = 0;
Expand Down Expand Up @@ -575,6 +579,7 @@ AlterDropPartitionExecutor::ManifestListWriteResult AlterDropPartitionExecutor::
components.path_resolver,
state.metadata_object,
object_storage,
external_storages,
context,
/*manifest_entry_names=*/{},
new_snapshot,
Expand Down
3 changes: 3 additions & 0 deletions src/Storages/ObjectStorage/DataLakes/Iceberg/AlterDropPartitionExecutor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ namespace DB

class FileNamesGenerator;
class IcebergMetadata;
struct ExternalStorageCache;

namespace Iceberg
{
Expand All @@ -42,6 +43,7 @@ class AlterDropPartitionExecutor
const IcebergMetadata & metadata_,
ContextPtr context_,
ObjectStoragePtr object_storage_,
ExternalStorageCache & external_storages_,
const PersistentTableComponents & components_,
const DataLakeStorageSettings & data_lake_settings_,
String write_format_,
Expand Down Expand Up @@ -106,6 +108,7 @@ class AlterDropPartitionExecutor
const IcebergMetadata & metadata;
ContextPtr context;
ObjectStoragePtr object_storage;
ExternalStorageCache & external_storages;
const PersistentTableComponents & components;
const DataLakeStorageSettings & data_lake_settings;
String write_format;
Expand Down
1 change: 1 addition & 0 deletions src/Storages/ObjectStorage/DataLakes/Iceberg/IcebergMetadata.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,6 +973,7 @@ void IcebergMetadata::alterPartitionDropImpl(const PartitionCommand & command, C
*this,
context,
object_storage,
*external_storages,
persistent_components,
data_lake_settings,
write_format,
Expand Down
Loading