Repository navigation
Conversation
publishCkpt labelled every non-fence give-up (policy deadline, lease deadline, unresolved) as persistent CAS contention. Route them through orThrow, which names the actual reason. Error code and class unchanged. Signed-off-by: Mikhail Filimonov <mfilimonov@altinity.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ref-log commit errors reported "could not be committed; retrying later" even when the transaction was already durable (only the `_ckpt` frontier publish failed) or its outcome was unknown. Name the outcome in the message: durable, unknown, or not durable. The original cause stays inside the text. Error codes and behaviour are unchanged. Signed-off-by: Mikhail Filimonov <mfilimonov@altinity.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Mikhail Filimonov <mfilimonov@altinity.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`orThrow` rendered every `Unresolved` give-up as "sent". A failed initial observation gives up unresolved before any request is sent. Signed-off-by: Mikhail Filimonov <mfilimonov@altinity.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Construct the outcome exception after the lane transition or `requireRecovery`, since building it can throw. The durable text now covers all three durable sites (frontier publish, mount fence, install admission) and embeds the cause without extra info or version. Signed-off-by: Mikhail Filimonov <mfilimonov@altinity.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Conflict in docs/en/antalya/cas/operations/troubleshooting.md: took the base's updated throttling row and kept this branch's commit-error row. Signed-off-by: Mikhail Filimonov <mfilimonov@altinity.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAS ref-log commit errors said "could not be committed; retrying later" even when the transaction was already durable (only the
_ckptfrontier publish failed) or its outcome was unknown. The messages now say which of three outcomes applies, so a client can tell whether a retry may duplicate the write.Texts only: behaviour is unchanged, and so are error codes for
DB::Exception; a non-DBexception from the store surfaces as aDB::Exceptioncarrying its message. The original error is kept inside the new message. The originalCAS write could not be committedlog line from the inner throw may still appear in the server log next to the client's message.Also,
publishCkptnow reports the real give-up reason (policy deadline, lease deadline, unresolved) instead of "persistent CAS contention".Related: #2343
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Content-addressed storage: a failed ref-log commit now says in its message whether the write is durable, of unknown outcome, or not durable, and so whether a client retry can duplicate it. Behaviour is unchanged.
Documentation entry for user-facing changes
docs/en/antalya/cas/operations/troubleshooting.md(#cas-commit-errors) anddocs/en/antalya/cas/architecture/part-lifecycle.md(crash rows C6, C10, C11).CI/CD Options
Exclude tests:
Regression jobs to run: