[PWGJE] added pvalue configurable, added safeguard for invalid EP values - #18034
Open
joachimckh wants to merge 3 commits into
Open
joachimckh wants to merge 3 commits into
joachimckh wants to merge 3 commits into
Conversation
|
O2 linter results: ❌ 0 errors, |
joachimckh
marked this pull request as ready for review
September 23, 2026 21:07
joachimckh
requested review from
alibuild,
fjonasALICE,
jaimenorman,
mhemmer-cern and
nzardosh
as code owners
September 23, 2026 21:07
nzardosh
reviewed
Sep 24, 2026
| } | ||
| return {.psi2 = epMap.at(cfgEPRefA), .psi3 = ep3Map.at(cfgEPRefA)}; | ||
| // check A is valid | ||
| bool isValidA{epMap.at(cfgEPRefA) != InvalidValue}; |
Collaborator
There was a problem hiding this comment.
is it intended here that you dont check if ep3Map is invalid or not?
Contributor
Author
There was a problem hiding this comment.
If its invalid then it's because of the amplitude which is used for both Psi2 and Psi3, so I thought it should be sufficient to check Psi2!
| registry.fill(HIST("eventQA/hEventCounterMixed"), kCentCut); | ||
|
|
||
| const auto psi{procEP<PsiFillerFalse>(c1)}; | ||
| if (!psi.isValid) { |
Collaborator
There was a problem hiding this comment.
should registry.fill(HIST("eventQA/hEventCounterMixed"), kEPValid) be filled before this?
Contributor
Author
There was a problem hiding this comment.
Yes, thanks - I'll add that now
Collaborator
nzardosh
self-requested a review
September 24, 2026 09:04
nzardosh
approved these changes
Sep 24, 2026
nzardosh
enabled auto-merge (squash)
September 24, 2026 09:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.