[PWGLF] Completed analysis task with (anti)Lambda and Omega cases + Introduced per-run efficiency fetching - #18033
Merged
Merged
Conversation
scannito
requested review from
HorstMa,
abmodak,
alibuild,
dmallick2,
ercolessi,
gbencedi,
lhusova,
maciacco,
mario-krueger,
mpuccio,
omvazque,
prottayCMT,
romainschotter,
skundu692 and
smaff92
as code owners
September 23, 2026 19:47
|
O2 linter results: ❌ 0 errors, |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Critical schema compatibility and moderate histogram, rapidity-selection, and closure-registration issues remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (3)
What changed in this PR
Extends phi–strangeness correlations with Lambda, anti-Lambda, and Omega candidates, plus per-run efficiency-map loading.
Changes:
- Adds candidate tables, selections, histograms, and MC handling.
- Extends correlation and closure workflows.
- Introduces period-dependent CCDB efficiency fetching.
| File | Summary and findings |
|---|---|
PWGLF/Tasks/Strangeness/phiStrangeCorrelation.cxx |
Adds new species and efficiency handling. Moderate: AntiLambda closure histograms are referenced but not registered. |
PWGLF/TableProducer/Strangeness/phiStrangeCorrelator.cxx |
Produces Lambda, anti-Lambda, and Omega candidates. Moderate: Lambda QA uses the K0S pT axis; charge-conjugate cascades use incorrect rapidity-selector indices. |
PWGLF/DataModel/LFPhiStrangeCorrelationTables.h |
Defines expanded reduced-candidate tables. Critical: Changed schema identifiers break compatibility with existing persisted AODs without migration/versioning. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| lf_selection_phi_candidate::InMassRegion<lf_selection_phi_candidate::M>); | ||
|
|
||
| DECLARE_SOA_TABLE(PhimesonCandidatesMcReco, "AOD", "PHICANDMCRECO", | ||
| DECLARE_SOA_TABLE(PhimesonCandidatesMcReco, "AOD", "PHICANDMCREC", |
romainschotter
approved these changes
Sep 23, 2026
romainschotter
enabled auto-merge (squash)
September 23, 2026 20:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.