Skip to content

ITSMFT: unify cellular automaton tracking for ITS and MFT - #15781

Open
mpuccio wants to merge 30 commits into
AliceO2Group:devfrom
mpuccio:itsmft-tracking
Open

mpuccio wants to merge 30 commits into
AliceO2Group:devfrom
mpuccio:itsmft-tracking

Conversation

@mpuccio

@mpuccio mpuccio commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Introduce shared tracking, propagation, material handling and runtime ROF tables with compatibility wrappers for legacy ITS callers.

Add ITS and MFT CA workflows with checked configuration, reusable workflow sessions and workflow-owned publication. Include tracking and workflow tests.

Introduce shared tracking, propagation, material handling and runtime ROF tables with compatibility wrappers for legacy ITS callers.

Add ITS and MFT CA workflows with checked configuration, reusable workflow sessions and workflow-owned publication. Include tracking and workflow tests.
@alibuild

alibuild commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 41e1eba at 2026-09-09 14:32:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
grep: error-log.txt: binary file matches
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Common/DCAFitter/GPU/cuda/GPUInterface.cu:55:15: error: use '= default' to define a trivial destructor [modernize-use-equals-default]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@ktf

ktf commented Sep 13, 2026

Copy link
Copy Markdown
Member

@mpuccio the issue on ARM is most likely due floating point associative math. Can you change the check to be a - b < epsilon?

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for e86650b at 2026-09-15 07:59:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Common/DCAFitter/GPU/cuda/GPUInterface.cu:55:15: error: use '= default' to define a trivial destructor [modernize-use-equals-default]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/ITSMFT/common/tracking/test/testGenericTrack.cxx:835:66: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRKFT3/FT3/base/src/GeometryTGeo.cxx:111:32: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRKFT3/FT3/base/src/GeometryTGeo.cxx:114:31: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRKFT3/FT3/base/src/GeometryTGeo.cxx:140:43: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRKFT3/FT3/base/src/GeometryTGeo.cxx:148:25: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRKFT3/FT3/base/src/GeometryTGeo.cxx:152:32: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRKFT3/FT3/base/src/GeometryTGeo.cxx:259:16: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRKFT3/FT3/base/src/GeometryTGeo.cxx:355:52: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRKFT3/FT3/base/src/GeometryTGeo.cxx:359:50: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRKFT3/FT3/base/src/GeometryTGeo.cxx:365:86: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRKFT3/FT3/base/src/GeometryTGeo.cxx:368:32: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@mpuccio
mpuccio marked this pull request as draft September 15, 2026 17:16
Estimate the first q/pT from all attached hits with a weighted circle fit,
using bounded storage and retaining the existing seed for field-off fits.
Initialize both surface conventions with diagonal variances
(1, 1, 1, 1, clamp(abs(q/pT), 1, 10)); inflate the previous diagonal by 25
and clear correlations for subsequent passes.

Add signed-curvature, short-lever-arm and invalid-input coverage.
Validated with run3-local3: 15 normalized-refit and 9 failure-contract
cases pass, and all 346 assessment objects reproduce the preserved
combined-circle MFT result exactly. Baseline fixture and staged library
remain unchanged.
@mpuccio
mpuccio marked this pull request as ready for review September 22, 2026 08:31
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for f1e2189 at 2026-09-22 11:05:

## sw/BUILD/O2-latest/log
Error: missing ; at end of rule at /sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/TPC/base/src/TPCBaseLinkDef.h:75:56
Error: missing ; at end of rule at /sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/TPC/base/src/TPCBaseLinkDef.h:83:135
Error: missing ; at end of rule at /sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/TPC/base/src/TPCBaseLinkDef.h:84:135
Error: missing ; at end of rule at /sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/ECal/base/src/ECalBaseLinkDef.h:19:48
Error: missing ; at end of rule at /sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/RICH/base/src/RICHBaseLinkDef.h:18:48
Error: missing ; at end of rule at /sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/MID/base/src/MI3BaseLinkDef.h:18:47


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/ITSMFT/ITS/workflow-ca/src/CATrackerSpec.cxx:193:77: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/ITSMFT/ITS/workflow-ca/src/CATrackerSpec.cxx:200:16: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/ITSMFT/MFT/workflow/src/CATrackerSpec.cxx:172:18: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/ITSMFT/MFT/workflow/src/CATrackerSpec.cxx:206:77: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/ITSMFT/MFT/workflow/src/CATrackerSpec.cxx:211:16: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRKFT3/FT3/base/src/GeometryTGeo.cxx:115:31: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@alibuild

alibuild commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for e5c01a0 at 2026-09-23 13:09:

## sw/BUILD/O2-latest/log
Error: missing ; at end of rule at /sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/TPC/base/src/TPCBaseLinkDef.h:75:56
Error: missing ; at end of rule at /sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/TPC/base/src/TPCBaseLinkDef.h:83:135
Error: missing ; at end of rule at /sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/TPC/base/src/TPCBaseLinkDef.h:84:135
Error: missing ; at end of rule at /sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/ECal/base/src/ECalBaseLinkDef.h:19:48
Error: missing ; at end of rule at /sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/MID/base/src/MI3BaseLinkDef.h:18:47
Error: missing ; at end of rule at /sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/RICH/base/src/RICHBaseLinkDef.h:18:48


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/GPU/GPUTracking/TRDTracking/GPUTRDTracker.cxx:700:42: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/GPU/GPUTracking/TRDTracking/GPUTRDTracker.cxx:707:42: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/ITSMFT/ITS/workflow-ca/src/CATrackerSpec.cxx:193:77: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/ITSMFT/ITS/workflow-ca/src/CATrackerSpec.cxx:200:16: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/ITSMFT/MFT/workflow/src/CATrackerSpec.cxx:172:18: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/ITSMFT/MFT/workflow/src/CATrackerSpec.cxx:206:77: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/ITSMFT/MFT/workflow/src/CATrackerSpec.cxx:211:16: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRKFT3/FT3/base/src/GeometryTGeo.cxx:115:31: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@alibuild

alibuild commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for a847fab at 2026-09-24 09:09:

No log files found

Full log here.

@mpuccio

mpuccio commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

Hi @ktf, if @f3sch does not object, I would merge this, fullCI ran yesterday and signaled some codecheck issues that I addressed in the last commit

@f3sch

f3sch commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

thanks @mpuccio, indeed it would be good to merge now since it does only touch little from a production point of view, it should be safe to merge and continue development on the dev branch.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants