Skip to content

docs(benchmarks): fix measure-cli script path - #1498

Open
hy3560 wants to merge 2 commits into
Agent-Field:devfrom
hy3560:fix/1446-measure-cli-path
Open

hy3560 wants to merge 2 commits into
Agent-Field:devfrom
hy3560:fix/1446-measure-cli-path

Conversation

@hy3560

@hy3560 hy3560 commented Sep 25, 2026

Copy link
Copy Markdown

What changed

  • Point the README and script usage examples to docs/benchmarks/performance/measure-cli.sh.
  • Add a Go regression test that verifies the local script paths in both examples resolve.

Fixes #1446

How it was checked

  • go build ./... — passed (Windows, Go 1.26.5).
  • go test ./docs/benchmarks/performance -count=1 and go vet ./docs/benchmarks/performance — passed.
  • Ran both measure-cli.sh --help examples from the repository root with Git Bash — usage printed.
  • git diff --check — passed.

The broader Windows checks are not fully clean: go vet ./... and some manual/law test packages reference Unix-only syscall.Kill / unix.Flock; separate existing UI/law assertions also fail on this checkout. GNU make is not installed here, so I could not run the repository wrapper make pr-ready. These failures are outside the changed files; CI on Linux is still needed.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@santoshkumarradha

Copy link
Copy Markdown
Member

Hey, thanks for the PR. Could you sign the CLA when you get a chance so we can review it?

@hy3560

hy3560 commented Sep 25, 2026

Copy link
Copy Markdown
Author

Thanks for the reminder. I have already signed the CLA, but CLA Assistant is still showing it as pending on this PR. I’ll retry its recheck flow; if it continues to block review, please let me know what additional step is needed. I also added the suggested one-line Unreleased changelog entry in the latest commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The performance README points to a measure script at the wrong path

3 participants