Discard incomplete streaming replies - #1497
Open
mikemikimike wants to merge 3 commits into
Open
mikemikimike wants to merge 3 commits into
mikemikimike wants to merge 3 commits into
Conversation
|
|
Member
|
Hey, thanks for the PR. Could you sign the CLA when you get a chance so we can review it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1467
Issue: #1467
Streams that end without a finish reason or [DONE] marker are discarded and retried, so partial replies are not retained in conversation history. Either explicit completion signal remains sufficient.
Tests: go test -count=1 -p 1 -timeout 15m ./internal/provider; go test -count=1 -run 'TestATruncatedProviderReplyIsNotSettledByTheSession|TestAnIncompleteReplyIsAskedAgainWithoutKeepingItsText|TestRepeatedIncompleteRepliesSayWhatWasDropped' ./internal/session; go test ./internal/manual/; go test -run Manual ./internal/tui3/ ./internal/session/.