Repository navigation
coresearch: CE64 + Moore + masking wiring map, six probes pinned - #1405
Conversation
…efects Board entry 2026-10-08-coresearch-ce64-moore-masking-wiring: the coresearch council on stockfish-rs inventory O1-O5, re-asked as Q0-Q5 after a premise audit. Outcome: every surviving idea goes beside CE64, not inside it; the three carriers already exist and lack wiring. Seven probes named in the operator's priority order (CE64, Moore, masking, shader driver in the loop). PROBE-CF-MANTISSA and PROBE-W-PRESERVE ran (causal-edge tests/ce64_op_contract.rs, 8 tests). Both predicted defects reproduce and are pinned two-sided: - a weight carrying Counterfactual (-6) runs the Synthesis average and is re-stamped -6; - forward returns W = 0 and bits 59..63 = 0 even when both operands carry them; learn and the single-field setters preserve both. Each pinned defect was disable-verified (one test red per disable). clippy -D warnings on causal-edge --all-targets reports 9 errors, all pre-existing in src/ (edge.rs, tables.rs, v2_layout_tests.rs); the new test file is clean. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
…ng ops Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
…iour Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
📝 WalkthroughWalkthroughThe change adds tests for CE64 operations, confidence replay, metadata prefilter masks, and Moore direction masks. It also adds a board entry with probe findings and updates the board indexes. ChangesProbe Validation and Findings
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The reported full-size measurement and the automated equivalence tests serve different purposes. No issue established here needs to block merging. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 63.41% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 41 functions across 4 files. (4 skipped: 4 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. A rabbit checks each mask with care Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 98cc9d5bb6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…mits nothing MetaFilter bounds are u8; awareness is 4 bits. accepts() rejects every row for awareness_min >= 16, but the lowering passed the bound to the pattern builder, whose care mask dropped the high bits and admitted every row. The fixture hid it by drawing bounds % 16; it now covers the full u8 domain for awareness_min and free_e_max. (Codex review on #1405.) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
CI's entries_index --check ran on the merge with main, which had gained the RBAC hot-plug socket entry; the committed index was one row short. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
There was a problem hiding this comment.
🔇 Additional comments (5)
crates/causal-edge/tests/ce64_op_contract.rs (1)
1-175: LGTM!.claude/board/entries/2026-10-08-coresearch-ce64-moore-masking-wiring.md (1)
1-162: LGTM!.claude/board/entries/README.md (1)
28-28: LGTM!Also applies to: 36-36
.claude/board/SUPERSESSION-INDEX.md (1)
17-17: 📐 Maintainability & Code QualityThe count updates are expected for a generated index.
CLAUDE.mdstates thatSUPERSESSION-INDEX.mdis generated, must not be hand-edited, and must be regenerated when its inputs change. The append-only rule does not prohibit regenerated measurement changes.crates/cognitive-shader-driver/examples/meta_prefilter_mask_probe.rs-181-182 (1)
181-182: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
⚠️ Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.Run the full-size probe in a test.
The reported
cargo test --example meta_prefilter_mask_probecheck does not callmain(): Cargo replaces it with the test harness. The test compares 200 filters over 1031 rows, so that check does not verify the reported 400-filter, 4099-row result. Add a#[test]that callsmain(), or move the full-size comparison into a test. Keeptest = trueso the existing tests still run. (doc.rust-lang.org)
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: CHILL
- Plan: Essentials
- Run ID:
89232ade-1490-47aa-8f81-a41577cfc8d8
📒 Files selected for processing (8)
.claude/board/SUPERSESSION-INDEX.md.claude/board/entries/2026-10-08-coresearch-ce64-moore-masking-wiring.md.claude/board/entries/README.mdcrates/causal-edge/tests/ce64_op_contract.rscrates/cognitive-shader-driver/Cargo.tomlcrates/cognitive-shader-driver/examples/meta_prefilter_mask_probe.rscrates/cognitive-shader-driver/examples/moore_plasticity_probe.rscrates/lance-graph-planner/tests/chain_confidence.rs
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.
What
This PR records the coresearch council's answer to stockfish-rs inventory items O1–O5, which ask how to wire thinking onto
CausalEdge64and the mask algebra. It also adds six runnable probes, in the operator's priority order: CE64, Moore, masking, with the shader driver kept in the loop.Board entry:
.claude/board/entries/2026-10-08-coresearch-ce64-moore-masking-wiring.md. It contains the exploration map (PROBE / PARK / SKIP) and states what was not searched. The council ratifies nothing.The council's main finding: every idea that survives goes beside CE64, not inside it. The three carriers (CE64 per edge,
ThoughtCtxper thought,MailboxSoA.metaand masks per population) already exist; what is missing is the wiring between them.Probes
Each probe is test-pinned two-sided, and each pinned behaviour was disable-verified red.
causal-edge/tests/ce64_op_contract.rsforwardreturns W = 0 and bits 59..63 = 0 even when both operands carry them.learnand the single-field setters preserve both.cognitive-shader-driver/examples/meta_prefilter_mask_probe.rs(test = true)MetaFilterlowers to a row mask built only fromternary_match_u32_to_mask_under, with no field extraction. 400 filters × 4099 rows give the same rows as the shipped selection-vectormeta_prefilter.moore_plasticity_probe.rs(+2 tests)grid & shift(grid, −d)viamask_shift_morton. The palette fold stays a value-plane LUT fold.lance-graph-planner/tests/chain_confidence.rsreplay_stepraises confidence 200 → 224 → 237 and then saturates, whileforward's own deduction falls. Self-revision raises confidence. A weight with zero confidence still adds confidence (128 → 137, from the 16-bin revise table).No production code changes. The probes pin current behaviour, so a fix has to flip a test on purpose.
Checks
cargo test -p causal-edgepasses, including--no-default-features(the new file is gated to v2).cargo test -p cognitive-shader-driver --example meta_prefilter_mask_probeand--example moore_plasticity_probepass.cargo test -p lance-graph-planner --test chain_confidencepasses.cargo clippy -p causal-edge --all-targets -D warningsreports 9 errors, all pre-existing insrc/. The new test file is clean.entries_index.py --writeandsupersession_index.pyregenerated.🤖 Generated with Claude Code
https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
Generated by Claude Code
Summary by CodeRabbit