Repository navigation
vocab: email (0x0B05, IAM domain, OGIT ogit:Email) + SpearPort 0x000A; drop count fuses - #325
Conversation
…0x000A The mail hub (spear) and the stalwart dir-sim directory need a classid to declare an RBAC plug against; nothing mail-shaped was minted. 0x05XX is the next clean domain slot (0x10XX would put a domain root on the V3 marker 0x1000). Paired with the lance-graph ogar_codebook mirror. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 41 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 65 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (5)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (5)
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe vocabulary assigns domain ChangesEmail vocabulary
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~12 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to The new email concept and Spear mappings are consistently assigned and registered in the supplied change context. No specific user-facing or operational regression is evident, so the change appears ready to merge after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. A rabbit stamped Mail on a tidy new row Comment |
|
Add Carrot credits or activate Agent usage billing to use Autopilot |
every_codebook_id_appears_in_class_ids_all requires every minted concept to carry a ClassView; the Mail mint missed it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
Replaces mailbox / mail_message with one concept, email (0x0501), read from OGIT ogit:Email (SGO; optional attributes from EmailCorrespondance). Mailboxes, folders and flags are columns of an email row. SpearPort maps Spear's public names onto canon: Email/Message -> email, Document/DriveItem -> the existing document (0x080B). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f10a5e197
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
email is OGIT ogit:Email and sits in 0x0BXX above the AuthStore profiles, so no Mail domain is opened. Per HOTPLUG-MIGRATION-GUIDE step 4 the global ALL.len() count pins are deleted: lance-graph-ogar's assert_codebook_parity checks the full bijection, and MirrorDrift reports drift per plug. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
What
email=0x0B050x0B), the next id aboveauth_ory_keto(0x0B04).ogit:Email(SGOentities/Email.ttl).email()registered inogar-class-view.SpearPort, app prefix0x000AEmail/Message→emailDocument/DriveItem→ the existingdocument(0x080B)SpearPort::class_id("Email")gives0x0B05_000A.Global count fuses removed, per
HOTPLUG-MIGRATION-GUIDE.md:count_fuse_matches_lance_graph_ogar_mirror(ogar-vocab).class_ids::ALL.len()pin incapability_registry.rs.MirrorDrifton bind), and by the lance-graph mirror parity test. A global count no longer does it.Docs:
docs/APP-CLASS-CODEBOOK-LAYOUT.mdgets a row for0x000ASpear.Earlier pushes on this branch
The first push minted a new
Maildomain (0x05XX) with inventedmailbox/mail_messageconcepts and bumped the count pins in lockstep. That broke the hot-plug pattern, and the concepts had no OGIT source. It is all gone: there is no new domain,0x05XXis unassigned again, and the one concept is OGIT-backed and sits in IAM.The ordering check in the test is now a
constassert, after clippyassertions_on_constantsfailed downstream.Verification
cargo check + test,clippy -D warnings,fmt --check.cargo clippy --workspace --all-targets -- -D warningsis clean.ogar-vocab(167 tests),ogar-class-view,ogar-rbacand the adapters pass.Merge order
lance-graph-ogarbuilds against OGARmain, so until this PR merges, lance-graph's mirror has anemailrow that OGARmainlacks. Merging this closes that gap.🤖 Generated with Claude Code
https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg