Repository navigation
feat: add localxpose loclx cli - #534
LocalXpose wants to merge 1 commit into
Conversation
cf16c68 to
3950cca
Compare
|
FYI @rr3khan with the GitHub Actions outage yesterday 😭 I had to push this again to trigger the PR checks. Let me know if there's anything I can do to help with this. |
40d2f6c to
cf16c68
Compare
JillRegan
left a comment
JillRegan
left a comment
There was a problem hiding this comment.
Hey, thanks for the contribution here! I just left a few comments. 😄
| } | ||
| for _, backendType := range availableBackends { | ||
| attempt := out.NewAttempt(importer.SourceOther(string(backendType), "")) | ||
| openKeyring, err := keyring.Open(keyring.Config{ |
There was a problem hiding this comment.
I think this loop might be opening the same keyring on every pass. backendType never gets passed into keyring.Open, so it uses the default backend each time.
| Name: "LocalXpose CLI", | ||
| Runs: []string{"loclx"}, | ||
| DocsURL: sdk.URL("https://localxpose.io/docs/cli"), | ||
| NeedsAuth: needsauth.IfAll( |
There was a problem hiding this comment.
main now has a NotForCommand helper. It only matches from the start of the command so it would stop things like loclx tunnel http --subdomain update from accidentally skipping auth. Might be worth swapping NotWhenContainsArgs for NotForCommand here!
| )} | ||
| } | ||
|
|
||
| var defaultEnvVarMapping = map[string]sdk.FieldName{ |
There was a problem hiding this comment.
The LocalXpose CLI docs use ACCESS_TOKEN and say account login falls back to $HOME/.access (not ~/.localxpose/.access). Does loclx also read LX_ACCESS_TOKEN?
3 participants
Overview
Provides a CLI plugin for the LocalXpose CLI and embedded GUI application. Supports conditional auth and importing from the OS keychain.
Type of change
How To Test
op plugin init loclxloclx account status(will fail if unauthenticated)Changelog
Authenticate the LocalXpose CLI and GUI apps using Touch ID and other unlock options with 1Password Shell Plugins.