Skip to content

ci(release): bump every v2 package together via fixed versioning - #1042

Open
taylanpince wants to merge 1 commit into
v2from
ci/v2-fixed-versions
Open

taylanpince wants to merge 1 commit into
v2from
ci/v2-fixed-versions

Conversation

@taylanpince

Copy link
Copy Markdown
Contributor

Summary

Addresses the Codex finding on #1037: that release bumps only the packages reached by changesets (and their dependents) to 2.3.48, leaving @0xsequence/core and others at 2.3.47. Because update-version embeds core's version, VERSION (sent by the provider as clientVersion) would report 2.3.47 from a 2.3.48 provider, and the release would not match the PUBLISHING.md claim that every package is staged at one version.

  • .changeset/config.json: replace linked with fixed: [["@0xsequence/*", "0xsequence"]]. linked only aligns versions among packages already being bumped; fixed bumps the whole group on any changeset. The unscoped 0xsequence package is listed explicitly since the glob does not match it.
  • PUBLISHING.md: describe the fixed versioning accurately.
  • Empty changeset for the changeset check.

Test plan

  • pnpm changeset status --verbose on this branch lists all 25 packages (including @0xsequence/core) at 2.3.48.
  • After merge, the Changesets action should regenerate changesets: Release / Deploy (v2) #1037 with every package at 2.3.48 and VERSION = '2.3.48'.

🤖 Generated with Claude Code

@taylanpince
taylanpince requested a review from a team October 20, 2026 13:46
@taylanpince
taylanpince requested a review from a team as a code owner October 20, 2026 13:46
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T13:49:28.449733Z 7888803 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

`linked` only aligns versions among packages that are already being
bumped, so the 2.3.48 release left core and other untouched packages at
2.3.47. `update-version` reads core's version, so VERSION (sent by the
provider as clientVersion) would have stayed at 2.3.47 while the
provider shipped as 2.3.48. Switch to `fixed` and include the unscoped
`0xsequence` package so any changeset releases every package at one
version, as PUBLISHING.md describes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant