From 643f59789c0d703a74ff6ed3033c967fda02115a Mon Sep 17 00:00:00 2001 From: Aydin Hassan Date: Thu, 22 Oct 2026 21:28:25 +0200 Subject: [PATCH] Register emphasis delimiter processors in CliExtension **bold** and _italic_ were never parsed because the asterisk and underscore delimiter processors were not registered. Co-Authored-By: Claude Opus 5.5 --- src/CliExtension.php | 4 ++++ test/CliExtensionTest.php | 36 ++++++++++++++++++++++++++++++++++++ 2 files changed, 40 insertions(+) diff --git a/src/CliExtension.php b/src/CliExtension.php index 1cd801d..844e819 100644 --- a/src/CliExtension.php +++ b/src/CliExtension.php @@ -20,6 +20,7 @@ use PhpSchool\CliMdRenderer\Renderer\ParagraphRenderer; use Kadet\Highlighter\KeyLighter; use League\CommonMark\Environment\EnvironmentBuilderInterface; +use League\CommonMark\Extension\CommonMark\Delimiter\Processor\EmphasisDelimiterProcessor; use League\CommonMark\Extension\CommonMark\Node\Block\FencedCode; use League\CommonMark\Extension\CommonMark\Node\Block\Heading; use League\CommonMark\Extension\CommonMark\Node\Block\ListBlock; @@ -92,6 +93,9 @@ public function register(EnvironmentBuilderInterface $environment): void ->addInlineParser(new InlineParser\OpenBracketParser(), 20) ->addInlineParser(new InlineParser\BangParser(), 10) + ->addDelimiterProcessor(new EmphasisDelimiterProcessor('*')) + ->addDelimiterProcessor(new EmphasisDelimiterProcessor('_')) + ->addRenderer(Document::class, new DocumentRenderer(), self::RENDERER_PRIORITY) ->addRenderer(Heading::class, new HeaderRenderer(), self::RENDERER_PRIORITY) ->addRenderer(ThematicBreak::class, new HorizontalRuleRenderer(), self::RENDERER_PRIORITY) diff --git a/test/CliExtensionTest.php b/test/CliExtensionTest.php index 1132399..d5b19d9 100644 --- a/test/CliExtensionTest.php +++ b/test/CliExtensionTest.php @@ -51,7 +51,12 @@ use League\CommonMark\Extension\CommonMark\Parser\Inline\HtmlInlineParser; use League\CommonMark\Parser\Inline\NewlineParser; use League\CommonMark\Extension\CommonMark\Parser\Inline\OpenBracketParser; +use League\CommonMark\Delimiter\DelimiterParser; use League\CommonMark\Node\Node; +use League\CommonMark\Parser\MarkdownParser; +use PhpSchool\CliMdRenderer\CliRenderer; +use Colors\Color; +use PHPUnit\Framework\Attributes\DataProvider; use PHPUnit\Framework\TestCase; class CliExtensionTest extends TestCase @@ -98,9 +103,40 @@ public function testExtensionConfiguresEnvironment(): void CloseBracketParser::class, OpenBracketParser::class, BangParser::class, + DelimiterParser::class, ], $inlineParsers); } + #[DataProvider('emphasisProvider')] + public function testEmphasisIsParsedAndRendered(string $markdown, string $nodeClass, string $expected): void + { + $environment = new Environment(); + $environment->addExtension(new CliExtension()); + + $document = (new MarkdownParser($environment))->parse($markdown); + $inline = $document->firstChild()?->firstChild(); + self::assertInstanceOf($nodeClass, $inline); + + $colors = new Color(); + $colors->setForceStyle(true); + $renderer = new CliRenderer($environment, $colors); + + self::assertSame($expected, $renderer->renderBlock($document)); + } + + /** + * @return array, string}> + */ + public static function emphasisProvider(): array + { + return [ + 'strong asterisk' => ['**bold**', Strong::class, "\e[1mbold\e[0m\n\n"], + 'strong underscore' => ['__bold__', Strong::class, "\e[1mbold\e[0m\n\n"], + 'emphasis asterisk' => ['*italic*', Emphasis::class, "\e[3mitalic\e[0m\n\n"], + 'emphasis underscore' => ['_italic_', Emphasis::class, "\e[3mitalic\e[0m\n\n"], + ]; + } + /** * @param Environment $environment * @param class-string $blockClass