From 98edfbd29efe5e1c5ba8003cf6351a11f023d57c Mon Sep 17 00:00:00 2001 From: Xianpeng Shen Date: Wed, 30 Sep 2026 10:40:44 +0300 Subject: [PATCH] docs: show the full clang version in the banner reports The banner's Thread Comment and Step Summary scenes showed `clang-format (v21) reports:` and `clang-tidy (v21) reports:`. cpp-linter fills that version from the tool's `--version` output as `x.y.z` (`VERSION_PATTERN` in `cpp_linter/clang_tools/__init__.py`), so a real report reads `clang-tidy (v21.1.0) reports:`. The banner now uses v21.1.0, the same as the home page of cpp-linter.github.io. The longer lines still fit: the widest row ends 40px inside the panel. --- assets/profile-banner-dark.svg | 2 +- assets/profile-banner-light.svg | 2 +- branding/profile-banner/generate.py | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/assets/profile-banner-dark.svg b/assets/profile-banner-dark.svg index ac74db5..b36f2fb 100644 --- a/assets/profile-banner-dark.svg +++ b/assets/profile-banner-dark.svg @@ -1 +1 @@ -cpp-linter: C/C++ pull requests that arrive already checked.A loop of the ways cpp-linter-action reports on a pull request: file annotations, a thread comment, the step summary, pull request reviews from clang-tidy and clang-format, and auto-fix.cpp-linterC/C++ pull requeststhat arrivealready checked.clang-format and clang-tidy, reported on the pull request.Annotationsfile-annotations1 / 6src/parser.cpp41int parse(const char *src) {42+char *end = 0;src/parser.cpp:42:15 [modernize-use-nullptr]use nullptrRun clang-format on src/parser.cppFile src/parser.cpp does not conform to Customstyle guidelines. (lines 42)Thread Commentthread-comments2 / 6github-actionscommentedCpp-Linter ReportSome files did not pass the configured checks!clang-format (v21) reports: 1 file(s) not formattedclang-tidy (v21) reports: 2 concern(s)Step Summarystep-summary3 / 6cpp-linter summaryCpp-Linter ReportSome files did not pass the configured checks!clang-format (v21) reports: 1 file(s) not formattedclang-tidy (v21) reports: 2 concern(s)src/parser.cpp:42:15: warning: [modernize-use-nullptr]use nullptrJob summary generated at run-timePull Request Reviewtidy-review4 / 6github-actionsreviewedclang-tidy diagnosticsuse nullptr [modernize-use-nullptr]Suggested change-char *end = 0;+char *end = nullptr;Commit suggestionPull Request Reviewformat-review5 / 6github-actionsreviewedclang-format suggestionSuggested change-if(ok){return 1;}+if (ok) {+return 1;+}Commit suggestionAuto-fixauto-fix6 / 6Commitsfix: handle an empty inputyoustyle: apply clang-format fixesauto-fix · 2 files changedclang-format -i runs on the files with style issues,and the result is pushed to the pull request branch. +cpp-linter: C/C++ pull requests that arrive already checked.A loop of the ways cpp-linter-action reports on a pull request: file annotations, a thread comment, the step summary, pull request reviews from clang-tidy and clang-format, and auto-fix.cpp-linterC/C++ pull requeststhat arrivealready checked.clang-format and clang-tidy, reported on the pull request.Annotationsfile-annotations1 / 6src/parser.cpp41int parse(const char *src) {42+char *end = 0;src/parser.cpp:42:15 [modernize-use-nullptr]use nullptrRun clang-format on src/parser.cppFile src/parser.cpp does not conform to Customstyle guidelines. (lines 42)Thread Commentthread-comments2 / 6github-actionscommentedCpp-Linter ReportSome files did not pass the configured checks!clang-format (v21.1.0) reports: 1 file(s) not formattedclang-tidy (v21.1.0) reports: 2 concern(s)Step Summarystep-summary3 / 6cpp-linter summaryCpp-Linter ReportSome files did not pass the configured checks!clang-format (v21.1.0) reports: 1 file(s) not formattedclang-tidy (v21.1.0) reports: 2 concern(s)src/parser.cpp:42:15: warning: [modernize-use-nullptr]use nullptrJob summary generated at run-timePull Request Reviewtidy-review4 / 6github-actionsreviewedclang-tidy diagnosticsuse nullptr [modernize-use-nullptr]Suggested change-char *end = 0;+char *end = nullptr;Commit suggestionPull Request Reviewformat-review5 / 6github-actionsreviewedclang-format suggestionSuggested change-if(ok){return 1;}+if (ok) {+return 1;+}Commit suggestionAuto-fixauto-fix6 / 6Commitsfix: handle an empty inputyoustyle: apply clang-format fixesauto-fix · 2 files changedclang-format -i runs on the files with style issues,and the result is pushed to the pull request branch. diff --git a/assets/profile-banner-light.svg b/assets/profile-banner-light.svg index c04f57c..7804460 100644 --- a/assets/profile-banner-light.svg +++ b/assets/profile-banner-light.svg @@ -1 +1 @@ -cpp-linter: C/C++ pull requests that arrive already checked.A loop of the ways cpp-linter-action reports on a pull request: file annotations, a thread comment, the step summary, pull request reviews from clang-tidy and clang-format, and auto-fix.cpp-linterC/C++ pull requeststhat arrivealready checked.clang-format and clang-tidy, reported on the pull request.Annotationsfile-annotations1 / 6src/parser.cpp41int parse(const char *src) {42+char *end = 0;src/parser.cpp:42:15 [modernize-use-nullptr]use nullptrRun clang-format on src/parser.cppFile src/parser.cpp does not conform to Customstyle guidelines. (lines 42)Thread Commentthread-comments2 / 6github-actionscommentedCpp-Linter ReportSome files did not pass the configured checks!clang-format (v21) reports: 1 file(s) not formattedclang-tidy (v21) reports: 2 concern(s)Step Summarystep-summary3 / 6cpp-linter summaryCpp-Linter ReportSome files did not pass the configured checks!clang-format (v21) reports: 1 file(s) not formattedclang-tidy (v21) reports: 2 concern(s)src/parser.cpp:42:15: warning: [modernize-use-nullptr]use nullptrJob summary generated at run-timePull Request Reviewtidy-review4 / 6github-actionsreviewedclang-tidy diagnosticsuse nullptr [modernize-use-nullptr]Suggested change-char *end = 0;+char *end = nullptr;Commit suggestionPull Request Reviewformat-review5 / 6github-actionsreviewedclang-format suggestionSuggested change-if(ok){return 1;}+if (ok) {+return 1;+}Commit suggestionAuto-fixauto-fix6 / 6Commitsfix: handle an empty inputyoustyle: apply clang-format fixesauto-fix · 2 files changedclang-format -i runs on the files with style issues,and the result is pushed to the pull request branch. +cpp-linter: C/C++ pull requests that arrive already checked.A loop of the ways cpp-linter-action reports on a pull request: file annotations, a thread comment, the step summary, pull request reviews from clang-tidy and clang-format, and auto-fix.cpp-linterC/C++ pull requeststhat arrivealready checked.clang-format and clang-tidy, reported on the pull request.Annotationsfile-annotations1 / 6src/parser.cpp41int parse(const char *src) {42+char *end = 0;src/parser.cpp:42:15 [modernize-use-nullptr]use nullptrRun clang-format on src/parser.cppFile src/parser.cpp does not conform to Customstyle guidelines. (lines 42)Thread Commentthread-comments2 / 6github-actionscommentedCpp-Linter ReportSome files did not pass the configured checks!clang-format (v21.1.0) reports: 1 file(s) not formattedclang-tidy (v21.1.0) reports: 2 concern(s)Step Summarystep-summary3 / 6cpp-linter summaryCpp-Linter ReportSome files did not pass the configured checks!clang-format (v21.1.0) reports: 1 file(s) not formattedclang-tidy (v21.1.0) reports: 2 concern(s)src/parser.cpp:42:15: warning: [modernize-use-nullptr]use nullptrJob summary generated at run-timePull Request Reviewtidy-review4 / 6github-actionsreviewedclang-tidy diagnosticsuse nullptr [modernize-use-nullptr]Suggested change-char *end = 0;+char *end = nullptr;Commit suggestionPull Request Reviewformat-review5 / 6github-actionsreviewedclang-format suggestionSuggested change-if(ok){return 1;}+if (ok) {+return 1;+}Commit suggestionAuto-fixauto-fix6 / 6Commitsfix: handle an empty inputyoustyle: apply clang-format fixesauto-fix · 2 files changedclang-format -i runs on the files with style issues,and the result is pushed to the pull request branch. diff --git a/branding/profile-banner/generate.py b/branding/profile-banner/generate.py index 7a63d0b..d7d0130 100644 --- a/branding/profile-banner/generate.py +++ b/branding/profile-banner/generate.py @@ -219,11 +219,11 @@ def scene_comment(c): out.append(text(IX + 18, y + 79, "Some files did not pass the configured checks!", "s", 11.5, c["ink"])) r1 = y + 90 out.append(g([rect(x + 10, r1, w - 20, 30, c["strip"], rx=6), caret(c, IX + 2, r1 + 15), - rich(IX + 14, r1 + 19, [("clang-format (v21) reports: ", 400, None), + rich(IX + 14, r1 + 19, [("clang-format (v21.1.0) reports: ", 400, None), ("1 file(s) not formatted", 600, None)], "s", 11.5, c["ink"])], cls="cl-r1")) r2 = r1 + 36 out.append(g([rect(x + 10, r2, w - 20, 30, c["strip"], rx=6), caret(c, IX + 2, r2 + 15), - rich(IX + 14, r2 + 19, [("clang-tidy (v21) reports: ", 400, None), + rich(IX + 14, r2 + 19, [("clang-tidy (v21.1.0) reports: ", 400, None), ("2 concern(s)", 600, None)], "s", 11.5, c["ink"])], cls="cl-r2")) return out @@ -236,10 +236,10 @@ def scene_summary(c): warn_icon(c, IX + 6, y + 62), text(IX + 18, y + 66, "Some files did not pass the configured checks!", "s", 11.5, c["ink"]), caret(c, IX + 2, y + 82), - rich(IX + 14, y + 86, [("clang-format (v21) reports: ", 400, None), + rich(IX + 14, y + 86, [("clang-format (v21.1.0) reports: ", 400, None), ("1 file(s) not formatted", 600, None)], "s", 11.5, c["ink"]), f'', - rich(IX + 14, y + 105, [("clang-tidy (v21) reports: ", 400, None), + rich(IX + 14, y + 105, [("clang-tidy (v21.1.0) reports: ", 400, None), ("2 concern(s)", 600, None)], "s", 11.5, c["ink"])] out.append(g([f'', rich(IX + 24, y + 124, [("src/parser.cpp:42:15:", 600, None),